[triggers] Support Item as parameter & Add arg type checks
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Unit tests for triggers can not be extended for Item as argument, because we need to mock Item first. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
enhancement
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@sfriedle Can you please review? Especially my changes to the unit tests please. |
florian-h05
changed the title
Item as parameter & Add arg type checksItem as parameter & Add arg type checks
|
Since the feature freeze is active now, this can not be merged before the release of 3.4.0 stable — only bug fixes are allowed from now on. |
sfriedle
reviewed
Dec 11, 2022
Signed-off-by: Stefan Friedle <stefan@friedle.de>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
sfriedle
approved these changes
Dec 12, 2022
Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Co-authored-by: Stefan Friedle <sfriedle@users.noreply.github.com>
florian-h05
changed the title
Item as parameter & Add arg type checksItem as parameter & Add arg type checks
florian-h05
added a commit
that referenced
this pull request
Dec 20, 2022
This should avoid that triggers get broken in the future like it happened in #194. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.
Description
typeOfArguments@runtimeand OSGi services (preparation for changes totriggers.js)Itemas argument for appropriate triggersTesting
All changes to
triggers.jsare automatically tested by our unit tests.