Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[items] ItemHistory: Add new methods #196

Merged
merged 4 commits into from
Dec 19, 2022
Merged

[items] ItemHistory: Add new methods #196

merged 4 commits into from
Dec 19, 2022

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 16, 2022 •
edited
Loading

Fixes #193.

Description

  • Adds four new methods, which were recently added to core, to the ItemHistory class.
  • Updates the ItemHistory JSDoc to fix ZonedDateTime
  • Improves the time JSDoc and adds the JS-Joda exports to the time JSDoc

To Do

  • Update CHANGELOG

@florian-h05 florian-h05 added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 16, 2022
@florian-h05 florian-h05 changed the title [items] ItemHistory: Add new methods [Do NOT merge] [items] ItemHistory: Add new methods Dec 16, 2022
@florian-h05 florian-h05 added this to the to be released milestone Dec 16, 2022
@florian-h05 florian-h05 changed the title [Do NOT merge] [items] ItemHistory: Add new methods [WIP] [items] ItemHistory: Add new methods Dec 19, 2022
@florian-h05 florian-h05 removed the request for review from digitaldan December 19, 2022 19:35
@florian-h05
[items] ItemHistory: Fix typos in JSDoc
47804d1 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
[items] ItemHistory: Add count**** methods
416438e 
Reference openhab/openhab-core#3145.
Reference openhab/openhab-core#3211.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
[items] ItemHistory: Fix param JSDoc
594c870 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 force-pushed the itemhistory-add-new-methods branch from 2276aad to 20610b0 Compare December 19, 2022 19:38
@florian-h05
Update CHANGELOG
d4a7a84 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 force-pushed the itemhistory-add-new-methods branch from 20610b0 to d4a7a84 Compare December 19, 2022 19:39
@florian-h05 florian-h05 changed the title [WIP] [items] ItemHistory: Add new methods [items] ItemHistory: Add new methods Dec 19, 2022
@florian-h05
Copy link
Contributor Author

I have tested this on my system, the additions work fine!

@florian-h05 florian-h05 merged commit 91a27e6 into openhab:main Dec 19, 2022
@florian-h05 florian-h05 deleted the itemhistory-add-new-methods branch December 19, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[items] ItemHistory: Add new persistence methods
1 participant
@florian-h05