[items & things] Add toString overrides & Clean-Ups
#198
Conversation
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
They were exported but undocumented so no one should have been using them and they are really advanced functionality. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@jpg0 Can I remove thing builder and channel builder here? |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
toString overrides & Clean-UpstoString overrides & Clean-Ups
Are they used? I don't mind whether they go or stay, I suppose it depends on the purpose of the library. I used them to define and register things and channels in scripts (and then refer to them from other scripts). I did this to move all my configuration into JS, and then could reference everything via JS imports instead of name strings. However if this library is limited to rules based on existing definitions, then this functionality should be removed. Maybe @digitaldan has an opinion? |
I would error on the side of simplicity. Since it's undocumented and probably unused by most, i think removing it makes sense. |
|
So we agree that we remove that? Can one of you please review here (although the changes apart from the removal are minimal). |
|
@jpg0 @digitaldan Can you please review here? You can ignore the |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Reference #197 (fixes the JS library side).
To Dos