Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[items] ItemHistory: Add previousStateTimestamp method #205

Merged

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 24, 2022

Required for openhab/openhab-webui#1597.

To Do

  • Update CHANGELOG
  • Update README

/cc @stefan-hoehn

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added the enhancement New feature or request label Dec 24, 2022
@florian-h05 florian-h05 added this to the to be released milestone Dec 24, 2022
items/item-history.js Outdated Show resolved Hide resolved
The import of typedefinitions in @typedef using an import() statement lead to JSDoc failure.
The newly added plugin translates to something JSDoc understands to avoid that failure.
See https://github.com/polyforest/jsdoc-tsimport-plugin.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title [items] ItemHistory: Add previousStateTimestamp method [items] ItemHistory: Add previousStateTimestamp method Dec 25, 2022
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

@digitaldan I am now using the internal import (as before), I was able to fix the problem with typedefs & JSDoc. This is ready for merging now.

Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@florian-h05 florian-h05 merged commit fd43464 into openhab:main Dec 26, 2022
@florian-h05 florian-h05 deleted the item-history-previousstate-timestamp branch December 26, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants