Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quantity] Initial contribution: Support UoM handling by wrapping QuantityType #206

Merged
merged 7 commits into from
Dec 26, 2022

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 25, 2022

Replaces #201.
Fixes #102.
Closes #200.
Fixes openhab/openhab-webui#836.

Description

This implementation of a Units of Measurement/Quantity handling functionality wraps the QuantityType from openHAB instead of introducing a new library.

I’ll add the docs later if this one gets accepted.

To Do

  • Update CHANGELOG

@digitaldan @jpg0
Can you please review this one?

The *.d.ts files can be ignored, they are autogenerated by the typescript compiler.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and i think the fact that it will match up with the official openHAB quantity api and docs is a very good thing.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title [Quantity] Initial contribution: Provide UoM handling by wrapping QuantityType [Quantity] Initial contribution: Support UoM handling by wrapping QuantityType Dec 26, 2022
@florian-h05 florian-h05 merged commit 46fa13e into openhab:main Dec 26, 2022
@florian-h05 florian-h05 deleted the wrap-quantitytype branch December 26, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants