Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules] Catch persistence exceptions in SwitchableJSRule creation #214

Conversation

florian-h05
Copy link
Contributor

When using SwitchableJSRule, script evaluation sometimes failed because the persistence service (in this case InfluxDB) has thrown an exception. This exception stopped script evaluation and therefore the rules below this SwitchableJSRule were not created.

Signed-off-by: Florian Hotze florianh_dev@icloud.com

When using `SwitchableJSRule`, script evaluation sometimes failed because the persistence service (in this case InfluxDB) has thrown an exception.
This exception stopped script evaluation and therefore the rules below this `SwitchableJSRule` were not created.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added the bug Something isn't working label Dec 30, 2022
@florian-h05 florian-h05 added this to the to be released milestone Dec 30, 2022
@florian-h05 florian-h05 changed the title [rules] Catch persistence exceptions in SwitchableJSRule [rules] Catch persistence exceptions in SwitchableJSRule creation Dec 30, 2022
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit b888f6b into openhab:main Dec 30, 2022
@florian-h05 florian-h05 deleted the switchablejsrule-catch-persistence-exceptions branch December 30, 2022 14:40
florian-h05 pushed a commit that referenced this pull request Feb 22, 2023
Fixes #246, which is a regression from #214.

Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Richard Koshak <rlkoshak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant