Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[items] Allow Item lookup by name directly on the items namespace #233

Merged
merged 10 commits into from
Feb 4, 2023
Merged

[items] Allow Item lookup by name directly on the items namespace #233

merged 10 commits into from
Feb 4, 2023

Conversation

digitaldan
Copy link
Contributor

Fixes #232

Signed-off-by: Dan Cunningham dan@digitaldan.com

@digitaldan
Allows item lookup by name directly on the item namespace
75991f8 
Fixes openhab#232

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

Hmm, i need to update the docs as well, i do that shortly

@digitaldan digitaldan added the workinprogress Work in Progress — not completed or tested label Feb 4, 2023
@digitaldan
add jsdocs
44fb8f9 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
JSDocs Tweaks
b64ff87 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Adding README, update JSDocs
a1e2c38 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Remove unused comment
c3c3baa 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
JSDocs update
45d513c 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan removed the workinprogress Work in Progress — not completed or tested label Feb 4, 2023
@digitaldan
Copy link
Contributor Author

Ok, was not sure the best way to document in JSDoc, this was the best i could come up with.

@florian-h05
Update type definitions
3c7baf0 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title Allows item lookup by name directly on the item namespace [items ]Allows Item lookup by name directly on the items namespace Feb 4, 2023
@florian-h05 florian-h05 changed the title [items ]Allows Item lookup by name directly on the items namespace [items] Allow Item lookup by name directly on the items namespace Feb 4, 2023
@florian-h05
Update CHANGELOG
3e05e8e 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
[items] Fix behaviour of static Item access when Item is missing
4c529ca 
Instead of returning null as intended, a exception was thrown.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Update README
9489e59 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
florian-h05 approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just a few minor things I will take care of:

  • static Item lookup throws exception if Item is missing instead of returning null as intended
  • README: Add comments to remaining items.getItem calls
  • type def updates
  • CHANGELOG update

@florian-h05 florian-h05 added the enhancement New feature or request label Feb 4, 2023
@florian-h05 florian-h05 added this to the to be released milestone Feb 4, 2023
@florian-h05 florian-h05 merged commit 1611948 into openhab:main Feb 4, 2023
@digitaldan
Copy link
Contributor Author

Thanks!

@florian-h05 florian-h05 mentioned this pull request Feb 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Add sendCommand and postUpdate to items
2 participants
@digitaldan @florian-h05