[items] Fix Item semantics location & equipment
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in the community, see https://community.openhab.org/t/itemsemantics/146294. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Yeah, a little hacky ;-) but i get the alternative might be a larger refactoring, maybe keep a refactor it in mind if this comes up again ? I think its ok for now. |
Yeah, if this comes up once again I'd refactor it into the items file, this is the only other solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in the community, see https://community.openhab.org/t/itemsemantics/146294.
Fixes an issue where the
locationandequipmentproperties were not available becausegetItemfailed.This happened because
items.jswas imported fromitem-semantics.jsanditems.jsimporteditem-semantics.js, which lead to a circular require and failed.This hacky fix passes the
getItemmethod via theItemSemanticsconstructor./cc @rkoshak