-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[utils] Add Java to JS conversion for Instant
& ZonedDateTime
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
FYI, I have benchmarked the performance of these implementations against toString and parsing that string: var Instant = Java.type('java.time.Instant');
var ins = Instant.now();
console.log('Benchmarking Instant.parse conversion ...')
var start = time.Instant.now().toEpochMilli();
for (var i = 0; i < 50; i++) {
time.Instant.parse(ins.toString())
}
var end = time.Instant.now().toEpochMilli();
console.log('Benchmark finshed, took ' + (end - start) + ' ms')
console.log('Benchmarking advanced Instant conversion ...')
var start = time.Instant.now().toEpochMilli();
for (var i = 0; i < 50; i++) {
utils.javaInstantToJsInstant(ins)
}
var end = time.Instant.now().toEpochMilli();
console.log('Benchmark finshed, took ' + (end - start) + ' ms')
var ZonedDateTime = Java.type('java.time.ZonedDateTime');
var zdt = ZonedDateTime.now();
console.log('Benchmarking ZonedDateTime.parse conversion ...')
var start = time.Instant.now().toEpochMilli();
for (var i = 0; i < 50; i++) {
time.ZonedDateTime.parse(zdt.toString())
}
var end = time.Instant.now().toEpochMilli();
console.log('Benchmark finshed, took ' + (end - start) + ' ms')
console.log('Benchmarking advanced ZonedDateTime conversion ...')
var start = time.Instant.now().toEpochMilli();
for (var i = 0; i < 50; i++) {
utils.javaZDTToJsZDT(zdt)
}
var end = time.Instant.now().toEpochMilli();
console.log('Benchmark finshed, took ' + (end - start) + ' ms') gives:
|
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
digitaldan
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new methods to the
utils
namespce and makes use of them internally:javaInstantToJsInstant
: Takes ajava.time.Instant
and returns a JS-Joda Instant.javaZDTToJsZDT
: Takes ajava.time.ZonedDateTime
and returns a JS-Joda ZonedDateTime. This was already implemented under thetime
namespace, but was private.