[rules] Preserve disabled state of switchable rules after restarting #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `SwitchableJSRule` has been switched off and I change something in my script so that it restarts, then after recreation of the rules the switch item would correctly be in `OFF` state given its historical state, but the rule it represents would still be enabled. Which basically means whenever your script restarts, all previously disabled rules would get enabled, without noticing... This should fix it, tested locally. Signed-off-by: Simon Ihmig <simon.ihmig@gmail.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
SwitchableJSRulehas been switched off and I change something in my script so that it restarts, then after recreation of the rules the switch item would correctly be inOFFstate given its historical state, but the rule it represents would still be enabled. Which basically means whenever your script restarts, all previously disabled rules would get enabled, without noticing...This should fix it, tested locally.