[time] Fix toZDT fails when injection caching is enabled because instanceof checks don't work
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Dec 17, 2023
Replaces the usage of `.raw` with `.rawQtyType`. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-addons
that referenced
this pull request
Dec 24, 2023
Regression from openhab/openhab-js#312. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
jlaur
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Dec 25, 2023
Regression from openhab/openhab-js#312. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
jlaur
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Dec 25, 2023
Regression from openhab/openhab-js#312. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…ab#16106) Regression from openhab/openhab-js#312. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…ab#16106) Regression from openhab/openhab-js#312. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
When
time.toZDTgot atime.ZonedDateTimepassed in from an external library, it failed to recognize that it in fact got atime.ZonedDateTimebecause instanceof checks were not working due to the webpack settings for the injection caching.Also fixes
utils.isJsInstanceOfJavanot working and renamesutils.isJsInstanceOfJavatoutils.isJsInstanceOfJavaType.