Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed location of files from Bintray to Artifactory and removed unused libs #21

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Changed location of files from Bintray to Artifactory and removed unused libs #21

merged 2 commits into from
Apr 26, 2021

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer
Changed location of files from Bintray to Artifactory
94f46b3 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from wborn April 26, 2021 17:49
@kaikreuzer kaikreuzer mentioned this pull request Apr 26, 2021
Closed
9 tasks
@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 26, 2021
@wborn
Copy link
Member

wborn commented Apr 26, 2021 •
edited
Loading

Shouldn't we also update the openhab-super-pom version? Did you also add all manually added JAR files to Artifactory?

@wborn
Copy link
Member

wborn commented Apr 26, 2021

We can probably also remove net.wimpi.jamod since it is embedded in the modbus-transport in openhab-core.

@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 26, 2021
@kaikreuzer
Copy link
Member Author

Looks as if we should upgrade lazysodium, which is now on Maven Central under a different group Id: https://github.com/terl/lazysodium-java/releases

@kaikreuzer
Copy link
Member Author

Nah, it can actually be removed as it isn't used either anymore...

@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 26, 2021
@wborn
Copy link
Member

wborn commented Apr 26, 2021

I did a local build and these still fail for me:

de.kaizencode.tchaikovsky
io.moquette.moquette-broker
org.java-websocket.java-websocket

@kaikreuzer
Copy link
Member Author

We are not using moquette anymore and I cannot find any references to java-websocket, so I guess we can remove them as well.

@kaikreuzer kaikreuzer changed the title Changed location of files from Bintray to Artifactory Changed location of files from Bintray to Artifactory and removed unused libs Apr 26, 2021
@kaikreuzer
removed further unused libraries
15d7c17 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Apr 26, 2021
@kaikreuzer
Copy link
Member Author

I'm only getting a bnd error: null: ConcurrentModificationException locally, that's why I couldn't test...

wborn
wborn approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it works now. 🙂 Thanks for your help! 👍

@wborn wborn merged commit 6da0713 into main Apr 26, 2021
@kaikreuzer
Copy link
Member Author

Finally green!

@cweitkamp cweitkamp deleted the alljoyn branch April 26, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikreuzer @wborn