Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic extensions.json file #101

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Added basic extensions.json file #101

merged 2 commits into from
Jun 19, 2018

Conversation

Confectrician
Copy link
Collaborator

Fixes #94

@kubawolanin can you give me the correct identifier for the tree-view extension?
I can add it to the json file then.

Signed-off-by: Jerome Luckenbach github@luckenba.ch

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@kubawolanin
Copy link
Collaborator

Sure thing, I believe it's DaGhostman.vs-treeview.
Marketplace: https://marketplace.visualstudio.com/items?itemName=DaGhostman.vs-treeview
GitHub: https://github.com/DaGhostman/vscode-tree-view

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@Confectrician
Copy link
Collaborator Author

Confectrician commented Jun 17, 2018

Then i already got the right one but wasn't sure.
Tree view is a very common term and gets many results in the extension search.

We could add a line about recommended addons in the readme file when #100 is done.

@@ -0,0 +1,6 @@
{
"recommendations": [
"eg2.tslint",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is TSLint a recommended package for openHAB? There's no *.ts files in OH configuration folder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shown, when you are working on the extension itself.
So "recommended for developing the extension"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we would want somethign for openHAB itself we would have to add an .vscode folder with that file in the OH configuration folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! Thanks for explanation ;)

@kubawolanin kubawolanin merged commit 13282d9 into openhab:master Jun 19, 2018
@Confectrician Confectrician deleted the feature/94-add-extensions-json branch June 28, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants