Add Hover provider, with rest api contents. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Confectrician
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ad a hover provider, that presents Item Informations in the editor.
restApiis needed for this.We should also think about a better handling in the future, to prevent the extension from requesting the rest api each time a text gets hovered.
This could be done with some kind of item caching through rest api on startup.
The hovered texts could then be compared to existing items, before making a rest api call.
Single Item Hover:
Group Item Hover:
Signed-off-by: Jerome Luckenbach github@luckenba.ch