-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update Notice #250
Add Update Notice #250
Conversation
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
@CWempe maybe you can find some time to check the spelling and look of the update page. Currently the Page will show up on each extension startup. |
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Latest change provides following behavior:
|
Im am no expert in english either, but here are some thoughts: current: current: btw: I just noticed there is a changelog tab in the marlked place: current: current: Looks good so far! 👍 I tested |
Thanks for the typo/grammar checks.
Did you click the link for testing? Every release has a description field. My idea was to provide the needed information there additionally to those small informations. Here is an example from openHAB Distro with much explanations in the description.
I would have sworn that this is already filled via https://github.com/openhab/openhab-vscode/blob/main/CHANGELOG.md on default.
Typo. Sorry and fixed. |
I did. And personally I like the release notes on GitHub. If the |
But the changelog is not meant for explanations of how to deal with breaking changes. If we would add user descriptions, it would break the mould of its original purpose. Btw the release notes are just a computed "mini changelog" cut out from changelog.md currently. |
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Ok, I understand. |
Anyways i think this will be a huge improvement compared to the current (more or less none) existing migration paths. I have some things in mind that will make it easy to add changing update instructions (or even other informational messages) into new versions with the codebase introduced here. |
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Fixes #249
Already done: