-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MainUI] /settings/things/<thing uid> requests entire things JSON from API #1650
Comments
After watching network inspector more, it seems that the thing-specific endpoint is used when opening the settings page for a specific thing, but then the broad request is also sent to |
I think the additional call is due to the thing picker used to select the bridge: openhab-webui/bundles/org.openhab.ui/web/src/components/config/controls/thing-picker.vue Lines 36 to 38 in 4dfb912
It could use a The rules picker should also append openhab-webui/bundles/org.openhab.ui/web/src/components/config/controls/rule-picker.vue Lines 35 to 37 in 4dfb912
|
Nice sleuthing! While ETag/Last-Modified support from openHAB would be nice, it may not be easy. Especially considering item state. Just adding ?summary to the bridge (and rules) calls would be extremely helpful. Perhaps if there were a ?bridgesOnly param for the former as well? |
Depends on openhab/openhab-core#3335. Will fetch items, things and rules with the `cacheable` parameter set when appropriate. Closes openhab#1650. Signed-off-by: Yannick Schaus <github@schaus.net>
Depends on openhab/openhab-core#3335. Will fetch items, things and rules with the `cacheable` parameter set when appropriate. Closes openhab#1650. Signed-off-by: Yannick Schaus <github@schaus.net>
Closes #1650. Depends on openhab/openhab-core#3335. Will fetch items, things and rules with the `staticDataOnly` parameter set when appropriate. Also-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Yannick Schaus <github@schaus.net>
The problem
I have a lot of things. With an even more ridiculous amount of channels. My /rest/things endpoint returns over 2.5MB of JSON. When I'm local, this takes nearly a second just to transfer. If I'm remote, it would take much longer. Right now, when I click on an individual thing to configure it, I notice that it's using /rest/things to load the data. I'm sure this takes a long time for the javascript to parse, as well.
Your suggestion
Instead, it should use
/rest/things/<thing UID>
to only load the relevant information for the current page.Your environment
The text was updated successfully, but these errors were encountered: