-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BaiscUI] Icon update ignoring the OH iconset #1790
Comments
What I have done in PR #1706 did not enhance the live update of the OH icon (when iconset is not classic). |
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this issue
Mar 13, 2023
Also trigger the update of the icon for a Colorpicker widget. Fix openhab#1790 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this issue
Mar 14, 2023
Fix openhab#1790 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
pushed a commit
that referenced
this issue
Mar 17, 2023
Fix #1790 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which UI are you reporting an issue for?
The problem
When an update event is received by Basic UI, the icon update ignores the iconset, meaning classic iconset is always considered. If your icon is not in the classic iconset, it can lead to either the icon disappearing or a wrong icon displayed because there is an icon with the same name in the classic iconset.
Expected behavior
Consider the iconset when updating the icon in the current page.
Additional information
The icon is properly retrieved when you open a new page. The problem is only when an update is triggered in the current page.
The text was updated successfully, but these errors were encountered: