Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign (add-on) configuration page #1935

Closed
florian-h05 opened this issue Jun 24, 2023 · 1 comment · Fixed by #1997
Closed

Redesign (add-on) configuration page #1935

florian-h05 opened this issue Jun 24, 2023 · 1 comment · Fixed by #1997
Labels
enhancement New feature or request main ui Main UI

Comments

@florian-h05
Copy link
Contributor

florian-h05 commented Jun 24, 2023

In #1891 (comment) @ghys wrote:

In fact maybe having the add-on's (formerly only binding's) configuration in the add-on store was a bad idea after all, as we could just have add-ons add entries to the settings menu like on iOS. So you would have e.g. "Philips Hue" directly under Settings and users wouldn't have to look for it in the add-on store, which was in the end really meant for browsing, installing and uninstalling, nothing more.
As for the logging, in fact it could have been a single consolidated page where you would configure levels for all loggers at once.

The removal of "Other Services" however offers an opportunity to adjust the Settings menu to keep it balanced when presented on two columns, as we could layout it like this:

  • Left column
    • 1st-tier Configuration: Things, Model, Items, Pages
    • 2nd-tier Configuration: Persistence, Tags (?), Transformations no need to have a section header title for those, just separate them from the 1st tier. There would be room for more, for instance "Metadata Namespaces" (allow the user to define their own namespaces).
    • Automation: Rules, Scenes, Scripts, Schedule
  • Right column
  • Add-ons: Bindings, Automation, UI, Other
  • Services (formerly System Services)

In #1891 (comment) @florian-h05 wrote:

2nd-tier Configuration: Persistence, ...

I'd probably keep persistence out of the main settings and only have it under the add-on settings in the right column.

For the addon setting, I can imagine having the list of installed addon with its icon and instead of just opening the addon settings from the config description, open the addon settings page as in the addon store.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 24, 2023
@florian-h05 florian-h05 changed the title Redesign add-on configuration Redesign (add-on) configuration page Jun 24, 2023
@ghys
Copy link
Member

ghys commented Aug 6, 2023

Just putting it out there, for future redesigns, I like the UI on the left here (with "cells" for the most important entities).

image
(source: https://sarunw.com/posts/swiftui-list-row-badge/)

I could see Things, Model, Pages, Rules, Scenes, Scripts (has to be an even number) as the cells and the rest of the configuration (Items, Schedule, Transformations...) in a regular list below.

@ghys ghys closed this as completed in #1997 Sep 1, 2023
ghys pushed a commit that referenced this issue Sep 1, 2023
Closes #1935.

- Moves transformations to a new list for visual separaration, as it is
only second class configuration.
- Renames System Services to System Settings.
- Add Add-on Settings, which opens the same settings page as the add-on
store, i.e. provides log, service config and persistence config (if
persistence service). Add-ons that only provide log settings are
considered advanced and hidden by default.
- Consolidate the add-on store and the newly added add-on settings into
a single place (refactoring included).
- Add doc links to Things, Items, pages, rules, scenes & scripts list
pages.
- Make some system settings advanced.
- Use a third column for large screens.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this issue Sep 23, 2023
Closes openhab#1935.

- Moves transformations to a new list for visual separaration, as it is
only second class configuration.
- Renames System Services to System Settings.
- Add Add-on Settings, which opens the same settings page as the add-on
store, i.e. provides log, service config and persistence config (if
persistence service). Add-ons that only provide log settings are
considered advanced and hidden by default.
- Consolidate the add-on store and the newly added add-on settings into
a single place (refactoring included).
- Add doc links to Things, Items, pages, rules, scenes & scripts list
pages.
- Make some system settings advanced.
- Use a third column for large screens.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants