Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasicUI] Update of visibility and label/icon colors not working for input element #2021

Closed
lolodomo opened this issue Aug 15, 2023 · 1 comment · Fixed by #2022
Closed

[BasicUI] Update of visibility and label/icon colors not working for input element #2021

lolodomo opened this issue Aug 15, 2023 · 1 comment · Fixed by #2022
Labels
basic ui Basic UI bug Something isn't working

Comments

@lolodomo
Copy link
Contributor

Update of label and icon colors is not working for the input sitemap element.
This is due to the unusual structure of this element having one additional div tag.
I will provide a fix
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Aug 15, 2023
@lolodomo
Copy link
Contributor Author

Update of the visibility of the element is also not working, for the same root cause.

@lolodomo lolodomo changed the title [BasicUI] Update of label and icon colors not working for input sitemap element [BasicUI] Update of visibility and label/icon colors not working for input sitemap element Aug 15, 2023
@lolodomo lolodomo changed the title [BasicUI] Update of visibility and label/icon colors not working for input sitemap element [BasicUI] Update of visibility and label/icon colors not working for input element Aug 15, 2023
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 16, 2023
@lolodomo
[BasicUI] Input element: Fix visibility and label/icon color
3eb6892 
Fix openhab#2021

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo mentioned this issue Aug 16, 2023
Merged
kaikreuzer pushed a commit that referenced this issue Sep 2, 2023
@lolodomo
[BasicUI] Input element: Fix visibility and label/icon color (#2022)
9799a32 
Fix #2021 

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer pushed a commit that referenced this issue Sep 2, 2023
@lolodomo @kaikreuzer
[BasicUI] Input element: Fix visibility and label/icon color (#2022)
3a5f2c1 
Fix #2021 

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this issue Sep 23, 2023
@lolodomo @stefan-hoehn
[BasicUI] Input element: Fix visibility and label/icon color (openhab…
4413997 
…#2022)

Fix openhab#2021

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BasicUI] Input element: Fix visibility and label/icon color lolodomo/openhab-webui
1 participant
@lolodomo