-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right padding on the main UI add-on store buttons #2456
Comments
Can you please help me to reproduce that issue? I can neither reproduce it on my real phone nor with the browsers dev tool device simulator. |
I have identified the problem, it seems to be this piece of CSS: .button {
padding-left: 5px;
padding-right: 0
} Apparently it's been added to <style lang="stylus">
.button
padding-left 5px
padding-right 0px
.input
width inherit
</style> When you don't add the "scoped" attribute to the style node in Vue 2, and redefine these global classes, they effectively have a global impact. cc @mherwege |
TBH I am wondering for what this styling is actually needed ... I can't see a problem without it. |
The reason is on this line: https://github.com/mherwege/openhab-webui/blob/a5ff0ef7481d2b5441528791aaca295f1899b3cb/bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/attribute-details.vue#L16 Without the styling, the clear button moves too much to the left, leaving lost space on the right of it. It matters, especially on small screens when the attributes are shown on the bottom of the page. |
Fixes openhab#2456. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Thanks for the hint, I have created a fix for this issue, that retains your styling, see #2500. |
Fixes #2456. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
The problem
Seems like the buttons have lost their right padding on narrow screens in the add-on store:
Expected behavior
Buttons with the right padding, like on wider screens:
Steps to reproduce
Your environment
Browser console
Browser network traffic
Additional information
The text was updated successfully, but these errors were encountered: