Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel links with a broken link fail to render #709

Closed
simonihmig opened this issue Dec 27, 2020 · 0 comments · Fixed by #807
Closed

Channel links with a broken link fail to render #709

simonihmig opened this issue Dec 27, 2020 · 0 comments · Fixed by #807
Assignees
Labels
bug Something isn't working main ui Main UI

Comments

@simonihmig
Copy link

The problem

When migrating from OH 2.5.x to 3.0 I ended up having items refer to non-existing things (uploaded .items file in UI, referring to onewire things with an old unique ID). When editing such an item in the UI, this is what you get:

Bildschirmfoto 2020-12-27 um 12 44 09

As you can see in the network tab, the REST API rightfully responds with a 404 for the old thing that does not exist anymore. But the UI does not handle this case gracefully, showing not any channel link.

Expected behavior

The UI should display

  • the broken channel link, with a way to remove that
  • the two healthy links (see successful requests below the 404)

Steps to reproduce

As described above, uploading an .items file with a broken channel definition should reproduce this error.

Your environment

runtimeInfo:
  version: 3.0.0
  buildString: Release Build
locale: de_DE
systemInfo:
  configFolder: /openhab/conf
  userdataFolder: /openhab/userdata
  logFolder: /openhab/userdata/logs
  javaVersion: 11.0.9
  javaVendor: Azul Systems, Inc.
  javaVendorVersion: Zulu11.43+88-CA
  osName: Linux
  osVersion: 4.19.118-v7l+
  osArchitecture: arm
  availableProcessors: 4
  freeMemory: 84200216
  totalMemory: 259522560
bindings:
  - amazonechocontrol
  - astro
  - denonmarantz
  - harmonyhub
  - hue
  - knx
  - onewire
  - openweathermap
  - squeezebox
clientInfo:
  device:
    ios: false
    android: false
    androidChrome: false
    desktop: true
    iphone: false
    ipod: false
    ipad: false
    edge: false
    ie: false
    firefox: false
    macos: true
    windows: false
    cordova: false
    phonegap: false
    electron: false
    nwjs: false
    webView: false
    webview: false
    standalone: false
    os: macos
    pixelRatio: 2
    prefersColorScheme: light
  isSecureContext: false
  locationbarVisible: true
  menubarVisible: true
  navigator:
    cookieEnabled: true
    deviceMemory: N/A
    hardwareConcurrency: 8
    language: de-DE
    languages:
      - de-DE
      - de
      - en
      - en-US
    onLine: true
    platform: MacIntel
  screen:
    width: 1680
    height: 1050
    colorDepth: 30
  support:
    touch: false
    pointerEvents: true
    observer: true
    passiveListener: true
    gestures: false
    intersectionObserver: true
  themeOptions:
    dark: light
    filled: true
    pageTransitionAnimation: default
    bars: filled
    homeNavbar: default
    homeBackground: default
    expandableCardAnimation: default
  userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36
    (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36
timestamp: 2020-12-27T12:08:07.890Z

Browser network traffic

See above.

@simonihmig simonihmig added bug Something isn't working main ui Main UI labels Dec 27, 2020
@ghys ghys changed the title [mainUI] Fails to render channel links with a broken link Channel links with a broken link fail to render Jan 14, 2021
@ghys ghys self-assigned this Jan 14, 2021
ghys added a commit to ghys/openhab-webui that referenced this issue Jan 14, 2021
Display links which are invalid (for instance, missing
thing or channel) and offer the option to remove them.
Cleanups.

Fixes openhab#709.

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys closed this as completed in #807 Jan 14, 2021
ghys added a commit that referenced this issue Jan 14, 2021
Display links which are invalid (for instance, missing
thing or channel) and offer the option to remove them.
Cleanups.

Fixes #709.

Signed-off-by: Yannick Schaus <github@schaus.net>
ghys added a commit that referenced this issue Jan 16, 2021
Display links which are invalid (for instance, missing
thing or channel) and offer the option to remove them.
Cleanups.

Fixes #709.

Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants