Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant: Rework metadata UI - Part 1 #1017

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Google Assistant: Rework metadata UI - Part 1 #1017

merged 1 commit into from
Apr 25, 2021

Conversation

eikowagenknecht
Copy link
Contributor

This adds the new GA parameters / classes to the UI, see openhab/openhab-google-assistant#196 for docs.

Also moved the child item parameters (thermostatTemperatureAmbient etc.) to another place so they don't get configuration parameters displayed that won't have any effect there.

Signed-off-by: Eiko Wagenknecht eiko.wagenknecht@web.de

@relativeci
Copy link

relativeci bot commented Apr 25, 2021

Job #88: Bundle Size — 10.46MB (~+0.01%).

0dda5db vs ba272c6

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 2.59% 3.25%
Changed assets by type (1/7)
            Current     Baseline
JS 8.12MB (~+0.01%) 8.12MB

View Job #88 report on app.relative-ci.com

Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghys ghys merged commit ec3cb6c into openhab:main Apr 25, 2021
hubsif pushed a commit to hubsif/openhab-webui that referenced this pull request May 6, 2021
Signed-off-by: Eiko Wagenknecht <eiko.wagenknecht@web.de>
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI enhancement New feature or request labels May 30, 2021
@ghys ghys changed the title Rework metadata UI for new GA binding Google Assistant: Rework metadata UI - Part 2 May 30, 2021
@ghys ghys changed the title Google Assistant: Rework metadata UI - Part 2 Google Assistant: Rework metadata UI - Part 1 May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants