Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unit from "lux" to "lx" on badges #1052

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

cweitkamp
Copy link
Contributor

  • Change unit from "lux" to "lx" on badges

We are using unit signs for temperature and humidity. The correct unit for illumination is lx.

See also https://en.m.wikipedia.org/wiki/Lux

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp requested a review from a team as a code owner May 17, 2021 19:19
@relativeci
Copy link

relativeci bot commented May 17, 2021

Job #120: Bundle Size — 10.44MB (~+0.01%).

0e168c1 vs b3680e8

Changed metrics (3/8)
Metric Current Baseline
Initial JS 1.6MB(+0.04%) 1.6MB
Cache Invalidation 17.9% 21.21%
Modules 1457(+0.07%) 1456
Changed assets by type (1/7)
            Current     Baseline
JS 8.14MB (~+0.01%) 8.14MB

View Job #120 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!
The frontend doesn't have access to the extent of the UoM functionality available in the backend and relies on reasonable hardcoded defaults instead - but at least the unit symbols can be made right :)

@ghys ghys merged commit f3b5d13 into openhab:main May 17, 2021
@cweitkamp cweitkamp deleted the patch-1 branch May 18, 2021 04:47
@ghys ghys added this to the 3.1 milestone May 30, 2021
@ghys ghys added main ui Main UI bug Something isn't working labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants