Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Consider height parameter for mapview sitemap element #1065

Merged
merged 1 commit into from
May 25, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #1064

Signed-off-by: Laurent Garnier lg.hc@free.fr

Fix openhab#1064

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from a team as a code owner May 25, 2021 17:10
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaikreuzer kaikreuzer added the bug Something isn't working label May 25, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone May 25, 2021
@kaikreuzer kaikreuzer merged commit f951297 into openhab:main May 25, 2021
@lolodomo lolodomo deleted the mapview_height branch May 25, 2021 19:51
@ghys ghys added the basic ui Basic UI label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BasicUI] Mapview elements in sitemap are always shown with same height
3 participants