Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basicui] Fix handling of buttons when only 1 button #1132

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #1131

Signed-off-by: Laurent Garnier lg.hc@free.fr

Fix openhab#1131

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from a team as a code owner July 14, 2021 16:44
@lolodomo
Copy link
Contributor Author

@kaikreuzer : could you please review this one ? It has no link with the autoupdate stuff.

@kaikreuzer
Copy link
Member

The code that you are changing suggests that the current behavior was a very deliberate decision and not an accidental bug.
Can you make any sense out of it, why it was done this way and what its intention might have been?

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 19, 2021

The code that you are changing suggests that the current behavior was a very deliberate decision and not an accidental bug.

I was expecting you will ask the question ;) I agree with you, it seems to be implemented deliberately like that.

Can you make any sense out of it, why it was done this way and what its intention might have been?

I have strictly no idea why it was decided to not show the state of the button ! And no idea why to implement something differently for 1 button versus n buttons.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for your answer! Let's just hope that we don't overlook anything that might now break by this change...

@kaikreuzer kaikreuzer merged commit 36658f5 into openhab:main Jul 24, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jul 24, 2021
@kaikreuzer kaikreuzer added the bug Something isn't working label Jul 24, 2021
@lolodomo lolodomo deleted the basicui_mappingonebutton branch July 24, 2021 09:27
@kaikreuzer kaikreuzer modified the milestones: 3.1, 3.2 Aug 1, 2021
@kaikreuzer kaikreuzer changed the title [basicUI] Fix handling of buttons when only 1 button [basicui] Fix handling of buttons when only 1 button Aug 1, 2021
@ghys ghys added the basic ui Basic UI label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[basicUI] Mappings with only one entry not correctly rendered
3 participants