Add rule template support

[ghys]

Closes #1082.

Signed-off-by: Yannick Schaus github@schaus.net

[relativeci]

Job #219: Bundle Size — 10.65MB (~+0.01%).

ae7452e vs 8ff4240

Changed metrics (1/8)

Metric	Current	Baseline
Cache Invalidation	1.24%	1.22%

Changed assets by type (1/7)

	Current	Baseline
JS	8.38MB (~+0.01%)	8.38MB

---

View Job #219 report on app.relative-ci.com

[ghys]

@kaikreuzer can you please answer this as I'm not 100% positive I got it right:

• do the rule templates only assist in creating the rule, and then the modules can be freely edited (and in that case, why save the templateUID and configuration as part of the rule?),

• or can the configuration be altered after the rule has been created, and the modules will be refreshed with the new values in placeholders (in that case, the UI should hide the modules and only display the parameters as described by the template when editing too?).

[kaikreuzer]

do the rule templates only assist in creating the rule, and then the modules can be freely edited

Yes, correct.

why save the templateUID and configuration as part of the rule?
can the configuration be altered after the rule has been created

The template UID is imho indeed not necessary.
The configuration is meant to enable configurations on rule level that are then automatically considered by the modules. It might well be that this is technically not yet fully implemented, so maybe better ignore these configurations in the UI for now.

If this is what you have implemented so far and you think it should be directly included in M3, please remove the WIP and I'll wait with launching the M3 build until the merge of this PR.

[ghys]

Yes it's what was implemented. There's the little issue we experienced yesterday that the template parameters are not checked when the rule is created (like all required parameters have been filled in) and the template might not be applied if there are errors.
Other than that I believe it works well overall, we can probably add the parameter checks in a follow-up PR. It would be nice to open the marketplace to rule templates early to accept contributions and iron out the eventual bugs then.
If you agree then I'll merge this.

[kaikreuzer]

Alright, let's merge then - thank you!