-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mainui] Fix addons details serviceId #1202
Conversation
The serviceId for details page in the addon store was not properly determined if the addonId did not start with marketplace:. Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
364e011
to
c7c59c6
Compare
Job #253: Bundle Size — 10.75MB (~+0.01%).Changed metrics (0/8)
|
You might want to address this problem too eventually: openhab-webui/bundles/org.openhab.ui/web/src/components/addons/addon-info-table.vue Line 50 in 9aeb301
i.e. every add-on not coming from the marketplace will be advertised as coming from the openHAB distribution.
If you want to postpone that to another PR I can accept this one in the meantime. |
The question is how to fix that. I must admit that I have no idea how to do requests. Of course it is easy to change it to I did a quick check that the l. 50: to determine the "source" l.50 could be changed to "Community Marketplace" (if starts with marketplace:), "openHAB Distribution" (if no prefix) and "Other" (if other prefix). Unfortunately I have no idea what l. 81 does. If you give me a hint, I can make the adjustments for this. |
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@ghys I tried to find a solution. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - both the solution and the code.
Eventually the "3rd Party (serviceId)" could be improved with a request to get the real label but it's not that important right now.
The serviceId for details page in the addon store was not properly determined if the addonId did not start with
marketplace:
.