-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockly enhancements 2 - scripts, ephemeris, persistence #1212
Conversation
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Job #268: Bundle Size — 10.58MB (+0.02%).Changed metrics (0/8)
|
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
…ehn/openhab-webui into blockly_enhancements_2
Done with all implementations, now waiting for the review |
Okay first off, thanks! I have one major hurdle with the date picker field: it is simply too big for what it brings to the table. It comes with another UI component library to render the calendar and as a result adds 5% to the entire size of the UI, or half a MB! The code wouldn't be loaded until the user brings up the Blockly editor but still. Also when the service worker is involved (if the UI is served using HTTPS) it would be preloaded anyway. The Actions tab has this report: Since Framework7 has its own date picker so I think it would be best to reimplement our own date picker field using this component instead (similar to the item/thing pickers), shouldn't be too hard to do, I'll give it a try. |
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made significant changes and I believe this is now ready for prime time.
Since we'll have a few weekly release candidates until the final 3.2 we'll have some time to test these!
Second part of the enhancements
... awaiting review
Note: I again struggled with the right way of the commits due to the bug fix included and the rebase with main...