Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly enhancements 2 - scripts, ephemeris, persistence #1212

Merged
merged 13 commits into from
Dec 5, 2021

Conversation

stefan-hoehn
Copy link
Contributor

@stefan-hoehn stefan-hoehn commented Nov 23, 2021

Second part of the enhancements

  • Add script support
  • Add ephemeris support
  • Add persistence

... awaiting review

Note: I again struggled with the right way of the commits due to the bug fix included and the rebase with main...

Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner November 23, 2021 19:23
@relativeci
Copy link

relativeci bot commented Nov 23, 2021

Job #268: Bundle Size — 10.58MB (+0.02%).

362d618 vs df7fb29

Changed metrics (0/8)

No changes

Changed assets by type (1/7)
            Current     Baseline
JS 8.53MB (+0.02%) 8.53MB

No changes


View Job #268 report on app.relative-ci.com

Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
@stefan-hoehn stefan-hoehn changed the title [WIP] Blockly enhancements 2 - scripts, ephemeris, persistence Blockly enhancements 2 - scripts, ephemeris, persistence Nov 27, 2021
@stefan-hoehn
Copy link
Contributor Author

Done with all implementations, now waiting for the review

@ghys
Copy link
Member

ghys commented Dec 4, 2021

Okay first off, thanks!

I have one major hurdle with the date picker field: it is simply too big for what it brings to the table. It comes with another UI component library to render the calendar and as a result adds 5% to the entire size of the UI, or half a MB! The code wouldn't be loaded until the user brings up the Blockly editor but still. Also when the service worker is involved (if the UI is served using HTTPS) it would be preloaded anyway. The Actions tab has this report:

image

Since Framework7 has its own date picker so I think it would be best to reimplement our own date picker field using this component instead (similar to the item/thing pickers), shouldn't be too hard to do, I'll give it a try.

ghys added 7 commits December 4, 2021 16:13
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Signed-off-by: Yannick Schaus <github@schaus.net>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made significant changes and I believe this is now ready for prime time.
Since we'll have a few weekly release candidates until the final 3.2 we'll have some time to test these!

@ghys ghys merged commit 97a36b7 into openhab:main Dec 5, 2021
@ghys ghys added this to the 3.2 milestone Dec 6, 2021
@ghys ghys added main ui Main UI enhancement New feature or request labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants