Taphold action on oh-label-card and oh-button #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponents upon tap and hold (or contextual menu call on desktop). Signed-off-by: Gautier Taravella <tarag@mailbox.org>
|
Somehow all the hard work seemed to be already done 👍 . |
Job #351: Bundle Size — 10.69MB (~+0.01%).Changed metrics (2/8)
|
|
Thanks! For completeness sake, could you elaborate how to chose to add this to oh-label-card & oh-button only and not components which perhaps could benefit from this as well? |
|
It's just a start to see how things goes (from a usage standpoint). I think these are the most generic components on which actions are used. In addition, there are others like toggle or roller shutter on which I don't think it would be a great choice to have this kind of action. |
ghys
added a commit
to ghys/openhab-webui
that referenced
this pull request
Mar 21, 2022
Bug introduced in openhab#1313 and breaking config sheets in various parts of the UI. Fixes openhab#1343. Fixes openhab/openhab-core#2850. Signed-off-by: Yannick Schaus <github@schaus.net>
This was referenced Mar 21, 2022
ghys
added a commit
that referenced
this pull request
Mar 21, 2022
Bug introduced in #1313 and breaking config sheets in various parts of the UI. Fixes #1343. Fixes openhab/openhab-core#2850. Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides another configurable action upon taphold (or calling contextual menu on desktop) in oh-label-cards and oh-buttons.
This is quite interesting for wall mounted interfaces when using canvas layout and a floor plan. A button controlling a light might do the basic action upon touch (toggle the light), and display a popup with additional actions upon hold (like dimming, color...).