Blockly datesupport fix #1410
Blockly datesupport fix #1410
Conversation
…ange item blocks, typos Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Job #427: Bundle Size — 10.74MB (~-0.01%). |
…erations (openhab#1412) Fixes openhab#1411. Signed-off-by: H. William Welliver III <william@welliver.org>
| @@ -368,6 +367,7 @@ | |||
| <shadow type="oh_item" /> | |||
| </value> | |||
| </block> | |||
| <block type="oh_item" /> | |||
There was a problem hiding this comment.
I would keep this green block where it was because it sort of serves as "header" of the group of block types related to items, the same way the green "thing picker" is the header of the things blocks, even if there's only one (or put these at the end of each group).
There was a problem hiding this comment.
I hear what you saying and I was thinking about it but I noticed that many people use these and think it is the state but it actually is "not more than a string". I would then go for putting both to the end which is probably a good compromise:
There was a problem hiding this comment.
Thinking about this further I would also put the "send command/update state" block immediately after "get state" as they're somewhat related and probably the most used.
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
…oehn/openhab-webui into blockly_datesupport_fix
|
It seems during the rebase I didn't signoff. How can I amend that later without making things worse? |
fix: when providing an item state to getZonedDateTime() it is not detected as string by ecma-script and replace() fails -> convert explicitly to String first