Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate expressions in configuration Arrays & Update actionPhotos docs #1519

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Evaluate expressions in configuration Arrays & Update actionPhotos docs #1519

merged 3 commits into from
Oct 9, 2022

Conversation

florian-h05
Copy link
Contributor

@ghys

This PR brings the docs updates and support for expressions in configuration arrays from PR #1510.

Improvements

  • Update the docs for the actionPhotos property to explain how to set up the config Array in YAML syntax.
  • Add support for evaluating expressions in config Arrays of custom widgets.

@florian-h05
[MainUI] Improve docs for the actionPhotos prop & Make Item start w…
afba1e9 
…ith uppercase

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
[MainUI] Regenerate component docs
2351184 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
[MainUI] widget-mixin: Evaluate expressions in Arrays
978ff14 
This adds support for evaluating expressions in Arrays of the configuration of a component.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner October 8, 2022 18:15
@florian-h05 florian-h05 mentioned this pull request Oct 8, 2022
Merged
@relativeci
Copy link

relativeci bot commented Oct 8, 2022

Job #558: Bundle Size — 11.34MB (-0.14%).

cae92d9(current) vs 7392525 main#557(baseline)

Metrics (5 changes)
                 Current
Job #558		      Baseline
Job #557
Initial JS 1.7MB(-0.02%) 1.7MB
Initial CSS 607.98KB 607.98KB
Cache Invalidation 20.06% 0.16%
Chunks 218(-2.24%) 223
Assets 242(-2.02%) 247
Modules 2007(-0.25%) 2012
Duplicate Modules 110 110
Duplicate Code 1.82% 1.82%
Packages 133 133
Duplicate Packages 15 15
Total size by type (1 change)
                 Current
Job #558		      Baseline
Job #557
CSS 856.02KB 856.02KB
Fonts 1.08MB 1.08MB
HTML 1.19KB 1.19KB
IMG 140.74KB 140.74KB
JS 9MB (-0.18%) 9.01MB
Media 295.6KB 295.6KB
Other 846B 846B

View job #558 report View main branch activity

ghys
ghys approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit e0b95d6 into openhab:main Oct 9, 2022
@ghys ghys changed the title [MainUI] Evaluate expressions in configuration Arrays & Update actionPhotos docs Evaluate expressions in configuration Arrays & Update actionPhotos docs Oct 9, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels Oct 9, 2022
@ghys ghys added this to the 3.4 milestone Oct 9, 2022
@florian-h05 florian-h05 deleted the widget-evaluate-expression-arrays branch October 9, 2022 07:43
@florian-h05 florian-h05 mentioned this pull request Oct 11, 2022
Merged
@crnjan crnjan mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @ghys