Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Paper UI, Classic UI and HABmin #154

Merged
merged 4 commits into from
Dec 29, 2019
Merged

Removed Paper UI, Classic UI and HABmin #154

merged 4 commits into from
Dec 29, 2019

Conversation

kaikreuzer
Copy link
Member

As decided in https://github.com/orgs/openhab/teams/architecture-council/discussions/1?from_comment=5#discussion-1-comment-5:

  • We deprecate Dashboard / Paper UI / HABmin / Classic UI
  • The aim of the new UI should be to also replace Basic UI / HomeBuilder and HABot on the long run; I'd leave this open for now and leave it to how progress goes. But this should imho be our vision.

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

FTR: I didn't yet remove the dashboard, because the existing UIs have a dependency on it (by providing a dashboard tile).

@ghys Once openhab/openhab-core#1290 is done, it would be great if you could move the code of the new UI (refactored to use the org.openhab namespace in core) to this repo (and remove the dashboard in this process).

@peuter The CometVisu wasn't in scope of the decision, mainly because nobody had it on the radar. I have to admit that I have no clue how many users this has for openHAB and whether it makes sense to continue supporting it for openHAB 3. What's your opinion on this?

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@Hilbrand
Copy link
Member

Dashboard seems to be removed from the bundle pom.xml, and the classic pom.xml is still present.

@wborn
Copy link
Member

wborn commented Dec 21, 2019

Can you also update the CODEOWNERS?

@wborn
Copy link
Member

wborn commented Dec 21, 2019

It will be easier to replace the old JAX-RS implementation without cometvisu. 😉

See: openhab/openhab-core#726 (comment)

@ghys
Copy link
Member

ghys commented Dec 21, 2019

@ghys Once openhab/openhab-core#1290 is done, it would be great if you could move the code of the new UI (refactored to use the org.openhab namespace in core) to this repo (and remove the dashboard in this process).

Will do, after the code gets in good shape, I hope to get some work done during the holiday season. Any suggestions for the bundle's name?
The dashboard tiles will also be featured in the UI after a REST endpoint is provided to expose them.

The aim of the new UI should be to also replace Basic UI / HomeBuilder and HABot on the long run; I'd leave this open for now and leave it to how progress goes. But this should imho be our vision.

Still having a different opinion on simply removing these, as opposed to leaving them be mature, dedicated & more lightweight takes on specific use cases, but I guess it'll depend on the evolution of sitemaps and the HABot card system. I think we should open separate issues for discussion of the future of these concepts. The main UI will nonetheless be a sitemap viewer and an HABot client so using Basic UI or the current HABot UI would be optional.

@peuter
Copy link
Member

peuter commented Dec 22, 2019

Well there are cometvisu users out there and I am one of them. I don't know how many they are, but I obviously have a strong intererest in continuing the openHAB<->CometVisu support.

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

@Hilbrand Thanks, my Git client caused some issues there - should be fixed now.
@wborn CODEOWNERS file is also updated.

@wborn
Copy link
Member

wborn commented Dec 23, 2019

This Travis cache can also be removed:

- bundles/org.openhab.ui.paper/npm_cache

And there's a suppression that's no longer necessary:

<suppress files=".+org.openhab.ui.paper.+" checks="OutsideOfLibExternalLibrariesCheck|ManifestExternalLibrariesCheck|BuildPropertiesExternalLibrariesCheck" />

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

Thanks @wborn, both done.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now.

@kaikreuzer kaikreuzer merged commit 0d51db2 into master Dec 29, 2019
@kaikreuzer kaikreuzer deleted the retireuis branch December 29, 2019 11:31
@kgoderis
Copy link

wborn added a commit to wborn/openhab-distro that referenced this pull request Jan 11, 2020
Related to: openhab/openhab-webui#154

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-distro that referenced this pull request Jan 13, 2020
Related to: openhab/openhab-webui#154

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-distro that referenced this pull request Jan 20, 2020
Related to: openhab/openhab-webui#154

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-distro that referenced this pull request Jan 21, 2020
Related to: openhab/openhab-webui#154

Signed-off-by: Wouter Born <github@maindrain.net>
@bwosborne2
Copy link

Should Home Builder be removed too?

@kaikreuzer
Copy link
Member Author

I didn't dare to suggest that yet, but if we had some simple wizard in the new UI for the initial setup, I'd be all for it. Wdyt, @ghys?

@bwosborne2
Copy link

I thought its main purpose was to create sitemaps for the now defunct Basic UI.
I now notice I guess it has not yet been removed though.

@ghys
Copy link
Member

ghys commented Feb 4, 2020

Yes, since its purpose is pretty much to help when beginning with a blank system, that was my idea as well - the UI would offer some kind of (optional, skippable) setup wizard on first run to configure some common things, maybe install some common add-ons to get the user started, and also eventually build an initial "skeleton" of items (Home Builder's main use case) would be one of its steps. Home Builder's code and other assets - translations etc. - should be reusable rather easily since the tech is similar.
As for sitemaps, it depends what this concept will become so I won't comment on these for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants