-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Paper UI, Classic UI and HABmin #154
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
FTR: I didn't yet remove the dashboard, because the existing UIs have a dependency on it (by providing a dashboard tile). @ghys Once openhab/openhab-core#1290 is done, it would be great if you could move the code of the new UI (refactored to use the @peuter The CometVisu wasn't in scope of the decision, mainly because nobody had it on the radar. I have to admit that I have no clue how many users this has for openHAB and whether it makes sense to continue supporting it for openHAB 3. What's your opinion on this? |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Dashboard seems to be removed from the bundle pom.xml, and the classic pom.xml is still present. |
Can you also update the CODEOWNERS? |
It will be easier to replace the old JAX-RS implementation without cometvisu. 😉 |
Will do, after the code gets in good shape, I hope to get some work done during the holiday season. Any suggestions for the bundle's name?
Still having a different opinion on simply removing these, as opposed to leaving them be mature, dedicated & more lightweight takes on specific use cases, but I guess it'll depend on the evolution of sitemaps and the HABot card system. I think we should open separate issues for discussion of the future of these concepts. The main UI will nonetheless be a sitemap viewer and an HABot client so using Basic UI or the current HABot UI would be optional. |
Well there are cometvisu users out there and I am one of them. I don't know how many they are, but I obviously have a strong intererest in continuing the openHAB<->CometVisu support. |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
This Travis cache can also be removed: Line 16 in 1851807
And there's a suppression that's no longer necessary:
|
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Thanks @wborn, both done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM now.
Related to: openhab/openhab-webui#154 Signed-off-by: Wouter Born <github@maindrain.net>
Related to: openhab/openhab-webui#154 Signed-off-by: Wouter Born <github@maindrain.net>
Related to: openhab/openhab-webui#154 Signed-off-by: Wouter Born <github@maindrain.net>
Related to: openhab/openhab-webui#154 Signed-off-by: Wouter Born <github@maindrain.net>
Should Home Builder be removed too? |
I didn't dare to suggest that yet, but if we had some simple wizard in the new UI for the initial setup, I'd be all for it. Wdyt, @ghys? |
I thought its main purpose was to create sitemaps for the now defunct Basic UI. |
Yes, since its purpose is pretty much to help when beginning with a blank system, that was my idea as well - the UI would offer some kind of (optional, skippable) setup wizard on first run to configure some common things, maybe install some common add-ons to get the user started, and also eventually build an initial "skeleton" of items (Home Builder's main use case) would be one of its steps. Home Builder's code and other assets - translations etc. - should be reusable rather easily since the tech is similar. |
As decided in https://github.com/orgs/openhab/teams/architecture-council/discussions/1?from_comment=5#discussion-1-comment-5:
Signed-off-by: Kai Kreuzer kai@openhab.org