Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sub-component for oh-cards footers to allow several text layouts #1545

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

tarag
Copy link
Contributor

@tarag tarag commented Nov 17, 2022

Allows nice layout of several text fragments in the footers with the layout built-in f7 framework. The use of this components needs the user to define an array in the YAML view.

Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@tarag tarag requested a review from a team as a code owner November 17, 2022 16:38
Signed-off-by: Gautier Taravella <tarag@mailbox.org>
@relativeci
Copy link

relativeci bot commented Nov 17, 2022

Job #604: Bundle Size — 15.94MiB (~+0.01%).

050c412(current) vs 7ee4750 main#603(baseline)

Metrics (2 changes)
                 Current
Job #604
     Baseline
Job #603
Initial JS 1.72MiB(+0.02%) 1.71MiB
Initial CSS 608.33KiB 608.33KiB
Cache Invalidation 83.68% 83.69%
Chunks 218 218
Assets 687 687
Modules 2008 2008
Duplicate Modules 110 110
Duplicate Code 1.82% 1.82%
Packages 133 133
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #604
     Baseline
Job #603
CSS 856.37KiB 856.37KiB
Fonts 1.08MiB 1.08MiB
HTML 1.21KiB 1.21KiB
IMG 140.74KiB 140.74KiB
JS 9.01MiB (~+0.01%) 9.01MiB
Media 295.6KiB 295.6KiB
Other 4.58MiB (~+0.01%) 4.58MiB

View job #604 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Thanks!
I would like to have a discussion on having component's slots match slots in the original components' slots though, it's a challenge code-wise but we can achieve this. The goal would be to allow slots that you can learn and rely on from the Framework7 documentation to be reflected in the OH widgets/components, in the YAML definition.

@ghys ghys merged commit 3ca7ba0 into openhab:main Dec 4, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels Dec 4, 2022
@ghys ghys added this to the 3.4 milestone Dec 4, 2022
@tarag
Copy link
Contributor Author

tarag commented Dec 5, 2022

Thanks.

Concerning the use of slots, that exactly what I thought when I made this PR. It would really be a great to be able to use all the slots of the original f7 components. That would provide so much more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants