Add tags & script language to script settings

[florian-h05]

Reference #1597.
Reference openhab/openhab-addons#14005.

Description

This PR extends the script settings to allow the user to set tags and change the MIME type after creation of the script.
The ability to add and edit tags was requested several times (I think also by @rkoshak).

The ability to change the MIME type of a script after creation is very important for openHAB 4, because Nashorn will (very likely) swap it's MIME type with GraalJS, but Nashorn scripts do not run on GraalJS without some changes. With the extended script settings, the user can just change the MIME type to the new MIME type of Nashorn.

The "Script" tag that all scripts have is hidden in the settings.

How it looks

Script Creation

Note that the "Tags" section is newly added and doesn't show the "Script" tag although it is present.

Editing a Script

Here has already been a settings popup. It has been extended with tags and the ability to change the MIME type:

Note that this script settings are from a Blockly script, therefore only Javascript versions (I've only installed GraalJS) are listed. If you open these settings for a normal script, you can change the MIME type to any of the available engines, e.g. Rules DSL.

Editing a Script in a Rule

The settings are newly introduced for this case and limited to the MIME type:

/ping @ghys @rkoshak @stefan-hoehn

[relativeci]

Job #667: Bundle Size — 15.96MiB (+0.01%).

2098fa1(current) vs 0f52ce4 main#666(baseline)

Metrics (1 change)

	Current Job #667	Baseline Job #666
Initial JS	1.73MiB	1.73MiB
Initial CSS	608.52KiB	608.52KiB
Cache Invalidation	90.47%	90.46%
Chunks	218	218
Assets	688	688
Modules	2007	2007
Duplicate Modules	108	108
Duplicate Code	1.8%	1.8%
Packages	133	133
Duplicate Packages	15	15

Total size by type (2 changes)

	Current Job #667	Baseline Job #666
CSS	856.56KiB	856.56KiB
Fonts	1.08MiB	1.08MiB
HTML	1.23KiB	1.23KiB
IMG	140.74KiB	140.74KiB
JS	9.04MiB (+0.02%)	9.03MiB
Media	295.6KiB	295.6KiB
Other	4.59MiB (+0.02%)	4.59MiB

---

View job #667 report View main branch activity

[stefan-hoehn]

I love the idea. Again a step forward to easier allow to the new ECMAScript version.

regarding the tags:

I recently added some more search criteria in /settings/rules/ (see #1540)
Maybe it is possible to show and search for the tags there (like in /settings/items/) as well?

[florian-h05]

I've just checked it:

• searching by tags works
• searching by script states works
• searching by UID works
• searching by description works

FYI: The code to list rules and the one to list scripts is the same and scripts are in fact only a special type of rules.

[florian-h05]

@ghys This is now ready for review, it's working fine on my system and doesn't print any errors to the console.

[stefan-hoehn]

Does it not only search for the tags but also show the tags?. Our idea until now was that everything that is searchable is also shown on the list and vice versa.

[florian-h05]

It also shows the tags -- it behaves exactly the same like the rule overview.

[ghys]

LGTM, thanks.

Another idea I had in to add a blue "Edit YAML" list button that would let you edit the script module resp. the entire script rule in a popup editor (similar to what you have in chart pages when you add e.g. a tooltip), but that's already very nice to have and can always be done later.

[ghys]

One tiny general remark:
this component is also used to edit script conditions.
I understand you probably took this into account and figured there was no reason the list of languages would be different from the action to the condition, so good enough, but just pointing it out.

[florian-h05]

Thanks for that information.
I wasn‘t aware of this, but as there is no difference in the list of available languages for actions and conditions, this should be fine.
If I see it correctly, this component also did not take into account whether it edits an action or a condition before this PR.