Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add-on information issues #1607

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fix add-on information issues #1607

merged 1 commit into from
Dec 26, 2022

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 24, 2022

Fixes the following issues:

  • Markdown documentation for JDBC features does not show
  • Documentation link for JDBC features results in 404 not found
  • Issue links always point to openhab-addons repository (also for UI add-ons and Zigbee, Zwave)
    This causes users not to find exising issues and causes them to create issues in the wrong repository

@wborn
Fix add-on information issues
894e348 
Fixes the following issues:

* Markdown documentation for JDBC features does not show
* Documentation link for JDBC features results in 404 not found
* Issue links always point to openhab-addons repository (also for UI add-ons and Zigbee, Zwave)
  This causes users not to find exising issues and causes them to create issues in the wrong repository

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner December 24, 2022 13:41
@relativeci
Copy link

relativeci bot commented Dec 24, 2022

Job #664: Bundle Size — 15.96MiB (-0.16%).

3c65b51(current) vs a34b124 main#663(baseline)

Metrics (3 changes)
                 Current
Job #664		      Baseline
Job #663
Initial JS 1.73MiB(-0.02%) 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.49% 90.48%
Chunks 218 218
Assets 688 688
Modules 2007(-0.3%) 2013
Duplicate Modules 108 108
Duplicate Code 1.8% 1.8%
Packages 133 133
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #664		      Baseline
Job #663
CSS 856.56KiB (-0.02%) 856.72KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.03MiB (-0.23%) 9.05MiB
Media 295.6KiB 295.6KiB
Other 4.59MiB (-0.09%) 4.59MiB

View job #664 report View main branch activity

ghys
ghys approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghys ghys merged commit bf47aeb into openhab:main Dec 26, 2022
@ghys ghys added bug Something isn't working main ui Main UI labels Dec 26, 2022
@ghys ghys added this to the 4.0 milestone Dec 26, 2022
@wborn wborn deleted the addon-info-fixes branch December 26, 2022 19:01
@wborn
Copy link
Member Author

wborn commented Jan 1, 2023

Can this fix also be cherry-picked to the 3.4.x branch @openhab/webui-maintainers ?

kaikreuzer pushed a commit that referenced this pull request Jan 1, 2023
@wborn @kaikreuzer
Fix add-on information issues (#1607)
b82a1db 
Fixes the following issues:

* Markdown documentation for JDBC features does not show
* Documentation link for JDBC features results in 404 not found
* Issue links always point to openhab-addons repository (also for UI add-ons and Zigbee, Zwave)
  This causes users not to find exising issues and causes them to create issues in the wrong repository

Signed-off-by: Wouter Born <github@maindrain.net>
@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Jan 1, 2023
@kaikreuzer
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wborn @kaikreuzer @ghys