Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customisation of temperature, humidity and luminance badges #1647

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Allow customisation of temperature, humidity and luminance badges #1647

merged 1 commit into from
Jan 20, 2023

Conversation

crnjan
Copy link
Contributor

@crnjan crnjan commented Jan 16, 2023

On oh-locations-tab it's not possible to override temperature, humidity and luminance since they are handled a bit differently, as per https://community.openhab.org/t/not-all-custom-badges-are-working-what-am-i-doing-wrong-temperature-and-humidity-wont-change/143434.

Signed-off-by: Boris Krivonog boris.krivonog@inova.si

@crnjan crnjan requested a review from a team as a code owner January 16, 2023 14:42
@crnjan crnjan closed this Jan 16, 2023
@crnjan crnjan reopened this Jan 16, 2023
@relativeci
Copy link

relativeci bot commented Jan 16, 2023 •
edited
Loading

Job #700: Bundle Size — 15.97MiB (0%).

4fce2d7(current) vs 420fbef main#699(baseline)

Metrics (1 change)
                 Current
Job #700		      Baseline
Job #699
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 0% 90.48%
Chunks 218 218
Assets 688 688
Modules 2011 2011
Duplicate Modules 108 108
Duplicate Code 1.8% 1.8%
Packages 133 133
Duplicate Packages 15 15
Total size by type (no changes)
                 Current
Job #700		      Baseline
Job #699
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.04MiB 9.04MiB
Media 295.6KiB 295.6KiB
Other 4.59MiB 4.59MiB

View job #700 report View main branch activity

@crnjan crnjan force-pushed the feature/badge_temp_hum_lum branch from ceade5d to 054b1ef Compare January 16, 2023 14:56
ghys
ghys approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ghys ghys merged commit a82f2b4 into openhab:main Jan 20, 2023
@ghys ghys changed the title allow customisation of temperature, humidity and luminance badges too Allow customisation of temperature, humidity and luminance badges Jan 20, 2023
@ghys ghys added enhancement New feature or request main ui Main UI labels Jan 20, 2023
@ghys ghys added this to the 4.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crnjan @ghys