Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MainUI] Analyzer: Use Item label instead of name if available #1682

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[MainUI] Analyzer: Use Item label instead of name if available #1682

merged 1 commit into from
Feb 9, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1679.

Signed-off-by: Florian Hotze florianh_dev@icloud.com

@florian-h05 florian-h05 requested a review from a team as a code owner February 5, 2023 13:39
@relativeci
Copy link

relativeci bot commented Feb 5, 2023 •
edited
Loading

Job #751: Bundle Size — 15.97MiB (~-0.01%).

6baff33(current) vs 981cd9b main#750(baseline)

Metrics (2 changes)
                 Current
Job #751		      Baseline
Job #750
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.48% 90.47%
Chunks 218 218
Assets 688 688
Modules 2009(-0.05%) 2010
Duplicate Modules 108 108
Duplicate Code 1.77% 1.77%
Packages 135 135
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #751		      Baseline
Job #750
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.01MiB (~-0.01%) 9.01MiB
Media 295.6KiB 295.6KiB
Other 4.61MiB (-0.01%) 4.62MiB

View job #751 report View main branch activity

@florian-h05
[MainUI] Analyzer: Use Item label instead of name if available
4bfb73e 
Fixes openhab#1679.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
ghys
ghys approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I didn't do this in the first place, there must have been a reason but can't recall! 🤷 So LGTM.

@ghys ghys added enhancement New feature or request main ui Main UI labels Feb 9, 2023
@ghys ghys added this to the 4.0 milestone Feb 9, 2023
@ghys ghys merged commit 9299886 into openhab:main Feb 9, 2023
@florian-h05 florian-h05 deleted the analyzer-item-label branch February 9, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Chart page title doesn’t use Item label
2 participants
@florian-h05 @ghys