Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SIP Client component docs #1695

Merged
merged 3 commits into from
Feb 12, 2023
Merged

Improve SIP Client component docs #1695

merged 3 commits into from
Feb 12, 2023

Conversation

florian-h05
Copy link
Contributor

Closes #1692.

Signed-off-by: Florian Hotze florianh_dev@icloud.com

@florian-h05
Improve SIP Client component docs
c032f77 
Closes openhab#1692.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 10, 2023 10:35
@florian-h05
Automatic doc updates for other components
d09b913 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci
Copy link

relativeci bot commented Feb 10, 2023 •
edited
Loading

Job #763: Bundle Size — 15.97MiB (~+0.01%).

0bfe392(current) vs 3d32372 main#762(baseline)

Metrics (1 change)
                 Current
Job #763		      Baseline
Job #762
Initial JS 1.73MiB(+0.03%) 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.48% 90.48%
Chunks 218 218
Assets 688 688
Modules 2010 2010
Duplicate Modules 108 108
Duplicate Code 1.77% 1.77%
Packages 135 135
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #763		      Baseline
Job #762
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.01MiB (~+0.01%) 9.01MiB
Media 295.6KiB 295.6KiB
Other 4.62MiB (+0.01%) 4.62MiB

View job #763 report View main branch activity

@florian-h05
oh-sipclient: Extend local settings description
bb8152a 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@ghys ghys added enhancement New feature or request main ui Main UI labels Feb 12, 2023
@ghys ghys added this to the 4.0 milestone Feb 12, 2023
@ghys ghys merged commit 48a3cb8 into openhab:main Feb 12, 2023
@florian-h05 florian-h05 deleted the oh-sipclient-docs branch February 12, 2023 13:44
@florian-h05 florian-h05 removed the enhancement New feature or request label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

SIP Widget: there is no need for two distinct dialogs to provide the password
2 participants
@florian-h05 @ghys