Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Widget UID & page ID on creation #1700

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1689.

Also mark label as required because the pagedesigner-mixin.js alerts if label is not set.

Signed-off-by: Florian Hotze florianh_dev@icloud.com

Fixes openhab#1689.

Also mark label as required because the pagedesigner-mixin.js alerts if label is not set.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 10, 2023 13:55
@relativeci
Copy link

relativeci bot commented Feb 10, 2023

Job #760: Bundle Size — 15.97MiB (~+0.01%).

b7e429a(current) vs dff3045 main#759(baseline)

Metrics (1 change)
                 Current
Job #760
     Baseline
Job #759
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.48% 90.48%
Chunks 218 218
Assets 688 688
Modules 2010 2010
Duplicate Modules 108 108
Duplicate Code 1.78%(+0.56%) 1.77%
Packages 135 135
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #760
     Baseline
Job #759
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.01MiB (~+0.01%) 9.01MiB
Media 295.6KiB 295.6KiB
Other 4.62MiB (+0.01%) 4.62MiB

View job #760 reportView main branch activity

@ghys ghys added enhancement New feature or request main ui Main UI labels Feb 12, 2023
@ghys ghys added this to the 4.0 milestone Feb 12, 2023
@ghys ghys merged commit 35f81ce into openhab:main Feb 12, 2023
@florian-h05 florian-h05 deleted the widgets-pages-validate-id branch February 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow illegal characters in custom widget name
2 participants