Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blockly] Add bitwise math operators #1722

Merged
merged 2 commits into from
Feb 19, 2023
Merged

[Blockly] Add bitwise math operators #1722

merged 2 commits into from
Feb 19, 2023

Conversation

stefan-hoehn
Copy link
Contributor

as requested in https://community.openhab.org/t/fleet-management-using-openhab/141928/8

two new math blocks were added for bitwise operations:

  • not
  • and, or, xor
  • shifts <<, >>, >>>

image

@stefan-hoehn
[blockly] add bitwise math operators
36e4446 
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner February 17, 2023 22:33
@relativeci
Copy link

relativeci bot commented Feb 17, 2023 •
edited
Loading

Job #786: Bundle Size — 16.23MiB (~+0.01%).

d9e3dc1(current) vs 402917c main#785(baseline)

Metrics (1 change)
                 Current
Job #786		      Baseline
Job #785
Initial JS 1.86MiB(-0.07%) 1.86MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.63% 90.63%
Chunks 218 218
Assets 688 688
Modules 2019 2019
Duplicate Modules 108 108
Duplicate Code 1.74% 1.74%
Packages 137 137
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #786		      Baseline
Job #785
CSS 857.62KiB 857.62KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.18MiB (~+0.01%) 9.18MiB
Media 295.6KiB 295.6KiB
Other 4.7MiB (~+0.01%) 4.7MiB

View job #786 report View main branch activity

@florian-h05
Fix documentation links
1b751c2 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
florian-h05 approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I've fixed the docs links.

@florian-h05 florian-h05 merged commit 0235b65 into openhab:main Feb 19, 2023
@florian-h05 florian-h05 deleted the blockly_bitops branch February 19, 2023 21:11
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 19, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Feb 19, 2023
@florian-h05 florian-h05 changed the title [blockly] add bitwise math operators [Blockly] Add bitwise math operators Feb 19, 2023
@stefan-hoehn stefan-hoehn mentioned this pull request Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stefan-hoehn @florian-h05