Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blockly] Add workspace search #1723

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

stefan-hoehn
Copy link
Contributor

this adds a really helpful plugin that allows to search within the blockly workspace via Cmd/Ctrl-F

it is based on https://github.com/google/blockly-samples/tree/master/plugins/workspace-search

it opens up a small search window at the top right and blackens the blocks that match the search string

image

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner February 17, 2023 23:00
@relativeci
Copy link

relativeci bot commented Feb 17, 2023

Job #787: Bundle Size — 16.25MiB (+0.09%).

397887d(current) vs d9e3dc1 main#786(baseline)

⚠️ Bundle contains 16 duplicate packages
⚠️ Bundle introduced one new package: @blockly/plugin-workspace-search

Metrics (3 changes)
                 Current
Job #787
     Baseline
Job #786
Initial JS 1.86MiB 1.86MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.64% 90.63%
Chunks 218 218
Assets 688 688
Modules 2020(+0.05%) 2019
Duplicate Modules 108 108
Duplicate Code 1.74% 1.74%
Packages 138(+0.73%) 137
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #787
     Baseline
Job #786
CSS 857.79KiB (+0.02%) 857.62KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.19MiB (+0.1%) 9.18MiB
Media 295.6KiB 295.6KiB
Other 4.71MiB (+0.1%) 4.7MiB

View job #787 reportView main branch activity

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 19, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Feb 19, 2023
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! You (accidentally, I think) added a new script tag which I removed.

Just some minor style issues with the search box in dark mode - I took care of them.
Only thing left is the color of the action buttons in the search box, but we cannot change the color because the buttons are static images.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title [blockly] add blockly workspace search [Blockly] Add workspace search Feb 19, 2023
@florian-h05 florian-h05 merged commit 17f12f5 into openhab:main Feb 19, 2023
@florian-h05 florian-h05 deleted the blockly_ws_search branch February 19, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants