Configuration & iPhone style fixes for the options widget action
#1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #820: Bundle Size — 16.25MiB (0%).Metrics (1 change)
Total size by type (no changes)
|
|
Here are some screenshots from the openHAB iOS app on iPhone XS: Portrait mode:Before: After: Landscape mode:Before: After: |
florian-h05
changed the title
options widget actionoptions widget action
|
@ghys Can you please review this PR with some „priority“ Yannick? Should be a fast review, only a few changed lines, and it would be nice to be able to use that actions menu in the iOS app. |
ghys
requested changes
Mar 3, 2023
|
@ghys I've addressed your review and tested it on my real hardware, looks even better now! |
|
I just need to rebase to get the CI build working (Karaf upgrade...) |
florian-h05
force-pushed
the
action-options
branch
from
62411bc to
093d6b7
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Fixes openhab#1210 and should have no negative side effects because having whitespaces at start or end of a command is very unlikely to happen, and for the label it doesn't matter at all. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
action-options
branch
from
093d6b7 to
2f899d1
Compare
ghys
approved these changes
Mar 3, 2023
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Mar 28, 2023
Fixes openhab#1806, which is regression from openhab#1734. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actionOptionsto avoid having whitespaces in commands sent to the server.