Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Support iconcolor for non OH source icons #1751

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Mar 4, 2023

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI labels Mar 4, 2023
@lolodomo lolodomo requested a review from a team as a code owner March 4, 2023 10:17
@lolodomo
Copy link
Contributor Author

lolodomo commented Mar 4, 2023

Here is the result with the following items and sitemap:

Number:Temperature CurrentTemp "Current Temp [%.1f °C]" <temperature> (GTest) [ "Measurement", "Temperature" ]
Number:Temperature SetpointTemp "Setpoint Temp [%.1f °C]" <temperature> (GTest) [ "Setpoint", "Temperature" ]
Number CurrentPressure "Pressure [%.0f hPa]" <"oh:classic:pressure">
String TestString "Test string [%s]"
sitemap test label="Tests"
{
        Frame {
                Default item=CurrentTemp icon="temperature" iconcolor=["pink"]
                Default item=CurrentPressure icon="if:wi:day-light-wind" iconcolor=[<=1010="red","orange"]
                Default item=SetpointTemp icon="iconify:wi:day-sunny-overcast" iconcolor=[<=15="blue","green"]
                Selection item=TestString icon="material:favorite" iconcolor=[=="test"="pink","yellow"]
        }
}

image

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaikreuzer kaikreuzer merged commit db7e7da into openhab:main Mar 4, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Mar 4, 2023
@lolodomo lolodomo deleted the basicui_iconcolor branch March 4, 2023 21:41
@kaikreuzer kaikreuzer changed the title [basicUI] Support iconcolor for non OH source icons [BasicUI] Support iconcolor for non OH source icons Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
basic ui Basic UI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants