[BasicUI] Remove support for List element #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hab#1277) Bumps https://github.com/markedjs/marked from 3.0.2 to 4.2.12. Only used in addon-details.vue where usage was adjusted to the new version. Also-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: dependabot[bot] <support@github.com>
Related to openhab/openhab-android#3285 This sitemap widget is not documented. It is not implemented neither in Android app nor iOS app. It was partially implemented in BasicUI but does not work well (it breaks the layout). Without any opened issue, we can be relatively sure that noone is using it. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
I guess you are right that this isn't used.
IIRC, I introduced this 13 years ago for being able to render log entries and did that for some demos. But we have better ways nowadays and BasicUI isn't meant for that.
Shall we also remove the widget from the sitemap DSL syntax?
|
Since |
Yes, I will do it tomorrow. |
Could you please manage that? |
lolodomo
added a commit
to lolodomo/openhab-core
that referenced
this pull request
Mar 5, 2023
Related to openhab/openhab-webui#1755 Related to openhab/openhab-android#3285 This sitemap widget is not documented. It is not implemented neither in Android app nor iOS app. It was implemented in BasicUI but was buggy. Support in BasicUI has been removed. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Mar 5, 2023
Follow-up openhab#1755 Related to openhab/openhab-core#3423 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Mar 5, 2023
Follow-up openhab#1755 Related to openhab/openhab-core#3423 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
pushed a commit
that referenced
this pull request
Mar 5, 2023
Follow-up #1755 Related to openhab/openhab-core#3423 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-core
that referenced
this pull request
Mar 5, 2023
Related to openhab/openhab-webui#1755 Related to openhab/openhab-android#3285 This sitemap widget is not documented. It is not implemented neither in Android app nor iOS app. It was implemented in BasicUI but was buggy. Support in BasicUI has been removed. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
pushed a commit
to openhab/openhab-core
that referenced
this pull request
Mar 5, 2023
Related to openhab/openhab-webui#1755 Related to openhab/openhab-android#3285 This sitemap widget is not documented. It is not implemented neither in Android app nor iOS app. It was implemented in BasicUI but was buggy. Support in BasicUI has been removed. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
3 tasks
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Related to openhab/openhab-webui#1755 Related to openhab/openhab-android#3285 This sitemap widget is not documented. It is not implemented neither in Android app nor iOS app. It was implemented in BasicUI but was buggy. Support in BasicUI has been removed. Signed-off-by: Laurent Garnier <lg.hc@free.fr> GitOrigin-RevId: 6d989ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openhab/openhab-android#3285
This sitemap widget is not documented.
It is not implemented neither in Android app nor iOS app.
It was partially implemented in BasicUI but does not work well (it breaks the layout).
Without any opened issue, we can be relatively sure that noone is using it.
Signed-off-by: Laurent Garnier lg.hc@free.fr