Sitemap editor: Fix attribute value capturing in parser & string value handling in widget detail view #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Job #843: Bundle Size — 16.25MiB (~+0.01%).Metrics (no changes)
Total size by type (2 changes)
|
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
florian-h05
changed the title
|
@openhab/webui-maintainers |
@florian-h05 @openhab/webui-maintainers Stop this for now. There still seems to be a type mismatch. While it is now clean in the UI? the wrong type is still passed to OH core (String iso Boolean). I am looking into a fix. |
florian-h05
pushed a commit
that referenced
this pull request
Mar 9, 2023
This is a fix for the remaining bug in #1781 Boolean parameters are now properly treated as booleans and not strings (which made the type normalizer fail in core, and blocked the sitemap from being rendered). See #1781 (comment). Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in #1745
Fix attribute values for
forceasitemandsendFrequencynot being captured properly in code tab.Fix boolean parameters
legend,forceasitemandswitchSupportnot interpreting string value correctly in widget detail view.