[BasicUI] Set color-scheme for OH icon #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have icon color depending on selected theme Fix openhab#1861 Will work only with SVG custom OH icons containing style="color-scheme: light dark" and currentColor as fill color. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
approved these changes
Jun 24, 2023
|
I don’t understand how the code is organized, in particular how this feature is mutually exclusive with “icon colors”, but wouldn’t it be sufficient to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to have icon color depending on selected theme
Fix #1861
Will work only with SVG custom OH icons containing style="color-scheme: light dark" and currentColor as fill color.
Signed-off-by : Laurent Garnier lg.hc@free.fr