Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page highlighting in sidebar #1967

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

ghys
Copy link
Member

@ghys ghys commented Jul 16, 2023

Fixes #1966.

Happens when you have pages prefixed with the name of another page.

Should fix https://github.com/openhab/openhab-core/issues/3693

Happens when you have pages prefixed with the name of another page.

Signed-off-by: Yannick Schaus <github@schaus.net>

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys requested a review from a team as a code owner July 16, 2023 19:52
@relativeci
Copy link

relativeci bot commented Jul 16, 2023

Job #1061: Bundle Size — 15.74MiB (~+0.01%).

19b80b7(current) vs 2856af1 main#1060(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1061
     Baseline
Job #1060
Initial JS 1.67MiB(~+0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1061
     Baseline
Job #1060
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~+0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1061 reportView main branch activity

@lolodomo lolodomo added bug Something isn't working main ui Main UI labels Jul 17, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone Jul 18, 2023
@florian-h05 florian-h05 merged commit acfdb59 into main Jul 18, 2023
@florian-h05 florian-h05 deleted the page-prefix-highlighting branch July 18, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - sidebar link, wrong highlighting
3 participants