Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer sidebar: Fix Thing pinning fails #1984

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Developer sidebar: Fix Thing pinning fails #1984

merged 1 commit into from
Jul 26, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jul 24, 2023 •
edited
Loading

Regression from #1661.

Using the cacheable list for Things leads to a failure because the status field is not available then.
This reverts the change from #1661 to this single REST request.

@florian-h05
Developer sidebar: Fix Thing pinning fails
1eba53f 
Regression from openhab#1661.

Using the cacheable list for Things leads to a failure because the status field is not available then.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jul 24, 2023
@florian-h05 florian-h05 requested a review from a team as a code owner July 24, 2023 11:59
@florian-h05
Copy link
Contributor Author

@ghys Sorry, you were right that staticDataOnly does not work for some of the requests made by the developer sidebar search. This fix should be backported to 4.x.

@relativeci
Copy link

relativeci bot commented Jul 24, 2023

Job #1079: Bundle Size — 15.75MiB (~-0.01%).

ad77358(current) vs cd3fde2 main#1078(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1079		      Baseline
Job #1078
Initial JS 1.67MiB(~-0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1079		      Baseline
Job #1078
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~-0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1079 report View main branch activity

@ghys ghys merged commit efa3345 into openhab:main Jul 26, 2023
@florian-h05 florian-h05 deleted the developer-sidebar-things-regression branch July 26, 2023 15:25
@florian-h05 florian-h05 added this to the 4.1 milestone Jul 26, 2023
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Jul 26, 2023
florian-h05 added a commit that referenced this pull request Jul 26, 2023
@florian-h05
Developer sidebar: Fix Thing pinning fails (#1984)
4378199 
Regression from #1661.

Using the cacheable list for Things leads to a failure because the
status field is not available then.
This reverts the change from #1661 to this single REST request.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
(cherry picked from commit efa3345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @ghys