Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer sidebar: Add search for transformations #1985

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Developer sidebar: Add search for transformations #1985

merged 1 commit into from
Sep 1, 2023

Conversation

florian-h05
Copy link
Contributor

Transformations are searchable by uid and label, and as the uid contains the type, also by type.

@florian-h05
Developer sidebar: Add search for transformations
e863405 
Transformations are searchable by uid and label, and as the uid contains the type, also by type.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner July 24, 2023 12:04
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jul 24, 2023
@relativeci
Copy link

relativeci bot commented Jul 24, 2023

Job #1080: Bundle Size — 15.75MiB (+0.02%).

0e90025(current) vs ad77358 main#1079(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1080		      Baseline
Job #1079
Initial JS 1.67MiB(+0.18%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1080		      Baseline
Job #1079
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB (+0.03%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~+0.01%) 4.72MiB

View job #1080 report View main branch activity

@florian-h05
Copy link
Contributor Author

@ghys Can you please have a look at this one and my other PRs?

@florian-h05 florian-h05 added this to the 4.1 milestone Aug 19, 2023
ghys
ghys approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems rather logical to have them as well, thanks!

@ghys ghys merged commit 5b515ce into openhab:main Sep 1, 2023
@florian-h05 florian-h05 deleted the developer-sidebar-transformations branch September 1, 2023 18:58
florian-h05 added a commit to florian-h05/openhab-docs that referenced this pull request Sep 13, 2023
@florian-h05
Update developer sidebar search docs
f655710 
Refs openhab/openhab-webui#1985.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Sep 13, 2023
Merged
stefan-hoehn pushed a commit to openhab/openhab-docs that referenced this pull request Sep 13, 2023
@florian-h05
Update developer sidebar search docs (#2135)
e91dafa 
Refs openhab/openhab-webui#1985.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this pull request Sep 23, 2023
@florian-h05 @stefan-hoehn
Developer sidebar: Add search for transformations (openhab#1985)
a903a35 
Transformations are searchable by uid and label, and as the uid contains
the type, also by type.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @ghys