-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign settings page & Add doc links #1997
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c271f0b
Settings page: Move transformations to extra list for optical separation
florian-h05 e4ec7bb
Settings page: Add add-on settings & Rename system services to settings
florian-h05 c71ef8d
Settings page: Add missing counters
florian-h05 461ade1
Settings page: Update transformations icon & description
florian-h05 6cdeb69
Settings page: Hide advanced add-on settings by default
florian-h05 7cd4f72
Settings page: Improve add-ons advanced logic
florian-h05 8c38d91
Add descriptions to Items, Things & transformations lists
florian-h05 99fc92e
Address review: "Show All" instead of "Show/Hide Advanced"
florian-h05 68b1d47
Address review: Add docs links to "empty state placeholder" and "x It…
florian-h05 c101bfd
Add missing i18n texts for no transformations
florian-h05 e987bd2
Consolidate add-on store & settings and rfc to own component
florian-h05 802eed2
Introduce advanced system settings & Use 3 cols on large screens
florian-h05 5be5734
Clean-Ups
florian-h05 b8f932b
Add doc links to missing lists (pages, rules, scenes, scripts)
florian-h05 311dcb1
Fix style issues with hidden elements
florian-h05 2f9be09
Move add-on store link to left panel
florian-h05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
bundles/org.openhab.ui/web/src/pages/settings/menu/add-on-section.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
<template> | ||
<div> | ||
<f7-block-title> | ||
Add-on Settings | ||
</f7-block-title> | ||
<f7-list class="search-list"> | ||
<f7-list-item | ||
v-for="a in addonsSettings" | ||
:key="a.uid" | ||
:link="'addons/' + a.uid + '/config'" | ||
:title="a.label" /> | ||
<f7-list-button v-if="!expanded && addonsInstalled.length > addonsSettings.length" color="blue" @click="expanded = true"> | ||
Show All | ||
</f7-list-button> | ||
</f7-list> | ||
</div> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
props: ['addonsInstalled', 'addonsServices'], | ||
data () { | ||
return { | ||
ready: false, | ||
expanded: false | ||
} | ||
}, | ||
computed: { | ||
addonsSettings () { | ||
if (this.expanded) return this.addonsInstalled | ||
return this.addonsInstalled.filter((a) => | ||
a.type === 'persistence' || | ||
this.addonsServices.findIndex((as) => as.configDescriptionURI.split(':')[1] === a.id) > -1 | ||
) | ||
} | ||
} | ||
} | ||
</script> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor detail I just noticed too late (it wouldn't have been blocking): in that left side menu the top-level entries' icons (Settings, Developer Tools, About) are "filled" and the sub-levels are "hollow", so in this case the icon should have been e.g.
f7:bag_fill
instead off7:bag
; again just a minor design quirk but it contributes to the consistency 😎There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that it should be changed for visual consistency, so here it is: #2053.